Skip to content

[Console] Fix Windows code page support #41210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

orkan
Copy link
Contributor

@orkan orkan commented May 13, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37385, Fix #35842, Fix #36324, Fix #37495, Fix #37278
License MIT

Corrects mojibake problem on Windows where an OEM code page was applied to an input string and then messed with PHP.internal_encoding setting used by the script. This caused strings with different encodings to be displayed on the console output.

@nicolas-grekas
Copy link
Member

Thank you @orkan.

@nicolas-grekas nicolas-grekas merged commit 49dd6ef into symfony:4.4 May 13, 2021
This was referenced May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants