Skip to content

[Notifier] Add missing charset to content-type for Slack notifier #41211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2021
Merged

[Notifier] Add missing charset to content-type for Slack notifier #41211

merged 1 commit into from
May 13, 2021

Conversation

norkunas
Copy link
Contributor

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Symfony HttpClient doesn't set charset for the Content-Type header when used with json request option so with each response slack includes:

"response_metadata" => array:1 [
  "warnings" => array:1 [
    0 => "missing_charset"
  ]
]

@norkunas norkunas requested a review from OskarStark as a code owner May 13, 2021 06:17
@carsonbot carsonbot added this to the 5.2 milestone May 13, 2021
@OskarStark
Copy link
Contributor

@nicolas-grekas is this expected behavior of http client?

OskarStark
OskarStark reviewed May 13, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case to avoid a regression in the future?

and maybe check other transports which are using the 'json' key?

@nicolas-grekas
Copy link
Member

Yes it is: application/json is an utf8-only content-type. The API is stupid...

@norkunas
Copy link
Contributor Author

Could you please add a test case to avoid a regression in the future?

and maybe check other transports which are using the 'json' key?

Will add a test.

I think this is specific only for slack, as by spec json must be in utf-8 so adding charset everywhere shouldn't be required.

@OskarStark
Copy link
Contributor

Fine thank you 👍🏻

OskarStark
OskarStark approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a test was added

@norkunas norkunas force-pushed the add-missing-charset-for-slack branch from 1de0473 to e642100 Compare May 13, 2021 08:16
@norkunas
Copy link
Contributor Author

After a test was added

Done ;)

@OskarStark OskarStark requested a review from nicolas-grekas May 13, 2021 08:42
@Nyholm
Copy link
Member

Nyholm commented May 13, 2021

Good catch, thanks Tomas.

@Nyholm Nyholm merged commit 35dbf8c into symfony:5.2 May 13, 2021
@norkunas norkunas deleted the add-missing-charset-for-slack branch May 13, 2021 09:59
This was referenced May 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Nyholm approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@norkunas @OskarStark @nicolas-grekas @Nyholm @carsonbot