[Finder] Fix gitignore regex build with "**" #41241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank your for your PR. Two questions:
|
b88efcb to
27e2c59
Compare
27e2c59 to
36ee1fe
Compare
|
@derrabus base changed, it should be 4.4, title also updated |
396c1b4 to
d91eafb
Compare
OskarStark
approved these changes
May 16, 2021
|
I can confirm that this PR fixes the issue for us, at least. Thanks! |
fabpot
approved these changes
May 16, 2021
d91eafb to
ce22d5d
Compare
|
Thank you @mvorisek. |
This was referenced May 19, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covered with tests, also faster, we do not have to explode the rule at all :)
ping @lindelius @OskarStark