[SecurityBundle] Change information label from red to yellow #41242
Conversation
|
Are you by any chance using the new authenticator system ( |
|
@wouterj let me check and I’ll report back soon edit: yes indeed my project uses the new security system |
|
I think there should be no extra color if no firewall is matched, element should be black. Consider public website with no auth at all. Should by developer "warned" or "errored" if no firewall match is expected? |
|
@pavol-tk if a firewall doesn't match, the security block isn't visible in the toolbar. The yellow color is shown when a firewall matches, but a user is not authenticated (this is currently red). |
|
@wouterj No firewall matched, and block is visible ...and red ... or am I missing something? screen.mp4 |
…matched (wouterj) This PR was merged into the 5.4 branch. Discussion ---------- [SecurityBundle] Hide security toolbar if no firewall matched | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41242 (comment) | License | MIT | Doc PR | - As reported by `@pavol`-tk, we currently show a red Security block in the toolbar if no firewall matched. I think we should instead leave the block out of the toolbar, just like we do with all other elements if there is no data for that request. cc `@javiereguiluz` as you're the best in these UX like decisions :) Commits ------- 75590aa [SecurityBundle] Hide Security item if no firewall matched
The red colour feels like an error, but being not authenticated is more like a warning (generally associated with yellow/orange) than an error (generally in red).
Feel free to close, cheers :)