[Security\Http] Fix handling secure: auto using the new RememberMeAuthenticator
#41254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secure: auto using the new RememberMeA…secure: auto using the new RememberMeAuthenticator
chalasr
commented
May 17, 2021
| @@ -104,6 +104,10 @@ public function createAuthenticator(ContainerBuilder $container, string $firewal | |||
| $loader->load('security_authenticator_remember_me.php'); | |||
| } | |||
|
|
|||
| if ('auto' === $config['secure']) { | |||
| $config['secure'] = null; | |||
| } | |||
There was a problem hiding this comment.
Here is the corresponding logic from the old implementation:
It is needed for:
4333d0b to
3fdc154
Compare
nicolas-grekas
approved these changes
May 18, 2021
|
Thank you @chalasr. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The created cookie was always secure when using
autobecause of some missing config normalization that should have been copied from the legacy rememberme implementation.