-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] Allow setting session options via DSN #41268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpFoundation] Allow setting session options via DSN #41268
Conversation
makraz
commented
May 18, 2021
•
edited
Loading
edited
Q | A |
---|---|
Branch? | 5.4 for bug fixes |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #41071 |
License | MIT |
Doc PR | N/A |
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/SessionHandlerFactory.php
Outdated
Show resolved
Hide resolved
Thanks for the PR. This looks like a new feature to me. As such, that's for 5.4. |
@nicolas-grekas thank you for the feedback. I updated the PR to let other handlers benefit from options. |
@makraz I force-pushed some changes on your fork. Could you please fetch it and add some test cases? |
Thank you, @nicolas-grekas, for the update. I will work on the test cases |
Friendly ping @makraz (rebase needed also) |
Thank you @makraz. |
Btw, PR adding tests + another adding doc would be really welcomed. |
Thanks @nicolas-grekas for merging my PR, and sure I will handle it 🙌 |