Skip to content

[Lock] Remove deprecated classes in Lock #41284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2021

Conversation

jderusse
Copy link
Member

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets /
License MIT
Doc PR /

Remove deprecated paths in Lock component

@carsonbot carsonbot added this to the 6.0 milestone May 19, 2021
@carsonbot

This comment has been minimized.

@StaffNowa

This comment has been minimized.

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a CHANGELOG entry for removals :)

@jderusse jderusse force-pushed the deprec-lock branch 2 times, most recently from 3fb16ec to 33dfba2 Compare May 19, 2021 19:23
@derrabus derrabus added the Lock label May 20, 2021
@carsonbot carsonbot changed the title Remove deprecated classes in Lock [Lock] Remove deprecated classes in Lock May 20, 2021
@jderusse jderusse force-pushed the deprec-lock branch 2 times, most recently from 358081b to e4dba8a Compare May 20, 2021 16:40
@nicolas-grekas
Copy link
Member

(rebase needed)

@jderusse
Copy link
Member Author

rebased

@nicolas-grekas
Copy link
Member

WDYT of the failures?

@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 5c73e8d into symfony:6.0 May 23, 2021
@jderusse jderusse deleted the deprec-lock branch May 23, 2021 16:32
@fabpot fabpot mentioned this pull request Nov 5, 2021
derrabus added a commit that referenced this pull request Nov 20, 2021
…face (jderusse)

This PR was merged into the 6.0 branch.

Discussion
----------

[FrameworkBundle] Remove code relating to old StoreInterface

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The interface has been remove in symfony/lock 5.0, (but FWB was still compatible with symfony/lock 4.4).

Now FWB conflicts with <5.4 we can finally remove this reference

I also forgot to remove the `$lockDefinition` definition in #41284

Commits
-------

a0a431c Remove code relating to old SotreInterface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants