[Workflow] Add support for getting updated context after a transition #41292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ceb187 to
a5052f8
Compare
This comment has been minimized.
This comment has been minimized.
fabpot
approved these changes
Jul 3, 2021
| 5.3 | ||
| --- | ||
|
|
||
| * Deprecate `InvalidTokenConfigurationException` | ||
| * Added `MermaidDumper` to dump Workflow graphs in the Mermaid.js flowchart format |
There was a problem hiding this comment.
Please revert all unrelated changes here. We don't need/want to update all the old changelogs. The convention changed only for new entries.
| } | ||
|
|
||
| /** | ||
| * Returns the context after the subject has transitionend. |
There was a problem hiding this comment.
Suggested change
| * Returns the context after the subject has transitionend. | |
| * Returns the context after the subject has transitioned. |
|
Thank you @lyrixx. |
a5052f8 to
571c75e
Compare
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a listener that lock the transition. Then, I need to give this
lock to my consumer. ATM, there is no easy way to pass a new resource
from a listener to the caller. I could add a new
tmpLockproperty on mysubject (this is what I did temporary), but I'm not confortable with
this hack.
By adding the final context (it could be updated, that the point of
listener) to the marking, I could easily get data back.
Finally, the PHP doc of WorkflowInterface::apply() tells us:
* @return Marking The new MarkingSo I think it's legit to add also the new context