[EventDispatcher] Remove LegacyEventDispatcherProxy #41304
Conversation
derrabus
commented
May 20, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
| 6.0 | ||
| --- | ||
|
|
||
| * Remove `LegacyEventDispatcherProxy` |
There was a problem hiding this comment.
Shall we use a short sentence like this in code removal? Or duplicate the message in UPGRADE-6.0.md that also contains the Use the ... instead?
There was a problem hiding this comment.
In this particular case, I don't think that anything beyond the note about the removal is helpful. That class is just plain obsolete now.
There was a problem hiding this comment.
When we have one, mentioning the replacement in the removal' UPGRADE instruction is good yes
846d667 to
42feaf5
Compare
|
Maybe worth fixing the psalm report in this PR? |
…ter) This PR was merged into the 6.0 branch. Discussion ---------- [EventDispatcher] Removed deprecated code | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - This remove deprecated code from EventDispatcher. The `LegacyEventDispatcherProxy` is removed in #41304. Is it necessary to update the Changelog or Upgrade.md that the classes are not configurable any more? Commits ------- 70b8b16 [EventDispatcher] Removed deprecated code
394be53 to
117516c
Compare
That's a good catch from Psalm. Since EventDispatcher has been bumped to 5.4 everywhere, we can safely drop the calls to |
117516c to
5054709
Compare
|
Thank you @derrabus. |