Skip to content

[Messenger] Remove dependency on bridge packages #41314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2021
Merged

[Messenger] Remove dependency on bridge packages #41314

merged 1 commit into from
May 23, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented May 20, 2021 •
edited
Loading

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This removes code deprecated in 5.1. This will force the user to install the bridge instead of only the symfony/messenger

@Nyholm Nyholm requested a review from sroze as a code owner May 20, 2021 06:49
@carsonbot carsonbot added this to the 6.0 milestone May 20, 2021
@derrabus
Copy link
Member

This change deserves a ChangeLog entry.

jderusse
jderusse reviewed May 20, 2021
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the CHANGELOG ;)

@Nyholm
Copy link
Member Author

Nyholm commented May 20, 2021

Thank you.
I've added a changelog.

The upgrade docs already included this change.

@Nyholm Nyholm force-pushed the 6.0-messenger branch 2 times, most recently from 07bdc6d to 59188d2 Compare May 20, 2021 13:48
@Nyholm Nyholm force-pushed the 6.0-messenger branch 2 times, most recently from 6ff76f0 to 339b31b Compare May 21, 2021 12:03
@nicolas-grekas
Copy link
Member

Thank you @Nyholm.

@nicolas-grekas nicolas-grekas merged commit 10184b1 into symfony:6.0 May 23, 2021
@fabpot fabpot mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse left review comments

@derrabus derrabus derrabus approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @derrabus @nicolas-grekas @jderusse @carsonbot