Skip to content

[Form] Remove deprecated code #41318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2021
Merged

[Form] Remove deprecated code #41318

merged 1 commit into from
May 31, 2021

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented May 20, 2021

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@yceruto yceruto requested a review from xabbuh as a code owner May 20, 2021 07:27
@carsonbot carsonbot added this to the 6.0 milestone May 20, 2021
@yceruto
Copy link
Member Author

yceruto commented May 20, 2021

I will continue with the rest tomorrow if no one takes care of it before. Cheers!

@yceruto yceruto force-pushed the form_remove_depr branch 2 times, most recently from c4ee93d to da0f36f Compare May 20, 2021 21:42
derrabus
derrabus approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the CS fix suggested by Fabbot. Other than that, I'm happy with the changes. 👍🏻

@yceruto
Copy link
Member Author

yceruto commented May 20, 2021

I fixed the issue spotted by fabbot.io (the last one is a false positive)

@nicolas-grekas
Copy link
Member

(rebase needed)

@yceruto yceruto force-pushed the form_remove_depr branch from d0bb2e3 to b64762c Compare May 24, 2021 02:11
@yceruto
Copy link
Member Author

yceruto commented May 24, 2021

(rebased)

nicolas-grekas
nicolas-grekas reviewed May 27, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check psalm reports and let us know if we they're false positive or not?
Please rebase also

@yceruto yceruto force-pushed the form_remove_depr branch from b64762c to 3f0f7e6 Compare May 27, 2021 18:06
@yceruto
Copy link
Member Author

yceruto commented May 27, 2021

Can you please check psalm reports and let us know if we they're false positive or not?

It looks like a false positive for me.

(rebased)

@nicolas-grekas
Copy link
Member

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit d1be34d into symfony:6.0 May 31, 2021
@yceruto yceruto deleted the form_remove_depr branch May 31, 2021 16:29
@fabpot fabpot mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yceruto @nicolas-grekas @derrabus @carsonbot