[HttpFoundation] remove deprecated code #41334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
azjezz
commented
May 20, 2021
•
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | n/a |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
0e0d078 to
6e74e9b
Compare
|
Hey! I think @pyrech has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
6e74e9b to
0f7f3bc
Compare
|
RFR, failure is unrelated. |
| @@ -16,7 +16,7 @@ | |||
| /** | |||
| * InputBag is a container for user input values such as $_GET, $_POST, $_REQUEST, and $_COOKIE. | |||
| * | |||
| * @author Saif Eddin Gmati <saif.gmati@symfony.com> | |||
| * @author Saif Eddin Gmati <azjezz@protonmail.com> | |||
There was a problem hiding this comment.
please submit this change on 5.2
| @@ -27,16 +27,16 @@ final class InputBag extends ParameterBag | |||
| * | |||
| * @return string|int|float|bool|null | |||
| */ | |||
| public function get(string $key, $default = null) | |||
| public function get(string $key, $default = null): string | int | float | bool | null | |||
There was a problem hiding this comment.
reverting as adding return types is a separate topic
| trigger_deprecation('symfony/http-foundation', '5.2', 'The "HEADER_X_FORWARDED_ALL" constant is deprecated, use either "HEADER_X_FORWARDED_FOR | HEADER_X_FORWARDED_HOST | HEADER_X_FORWARDED_PORT | HEADER_X_FORWARDED_PROTO" or "HEADER_X_FORWARDED_AWS_ELB" or "HEADER_X_FORWARDED_TRAEFIK" constants instead.'); | ||
| } | ||
| self::$trustedProxies = array_reduce($proxies, function ($proxies, $proxy) { | ||
| self::$trustedProxies = array_reduce($proxies, static function ($proxies, $proxy) { |
There was a problem hiding this comment.
reverting as this might create needles merge conflicts and is not needed: the surrounding method is already static, so is this closure.
Signed-off-by: azjezz <azjezz@protonmail.com>
0f7f3bc to
8312f90
Compare
|
Thank you @azjezz. |
fabpot
added a commit
that referenced
this pull request
Oct 12, 2021
…obion) This PR was merged into the 6.0 branch. Discussion ---------- [HttpFoundation] remove legacy session lifetime logic | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This part was only relevant for keeping bc with the old lifetime data. Has been forgotten to be removed in #41334 and #43120 Commits ------- 54a578b [HttpFoundation] remove legacy session lifetime logic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.