[HttpKernel] Fix compatibility with Symfony6 #41343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For 5.3? |
src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/EventListener/SessionListener.php
Outdated
Show resolved
Hide resolved
e6dd9a1 to
d415983
Compare
Rebased.. But 5.3 is not compatible with FWB 6.0 |
d415983 to
25e79f0
Compare
OK, then let's go on 5.4. Don't miss adding changelog+upgrade files entries. |
25e79f0 to
9b23f2a
Compare
chalasr
requested changes
May 23, 2021
src/Symfony/Component/HttpKernel/EventListener/SessionListener.php
Outdated
Show resolved
Hide resolved
9b23f2a to
9dc5253
Compare
chalasr
approved these changes
May 23, 2021
nicolas-grekas
requested changes
May 23, 2021
Kocal
reviewed
May 24, 2021
src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php
Outdated
Show resolved
Hide resolved
a9e3e16 to
da40387
Compare
ff8b9fb to
b317830
Compare
b317830 to
0458384
Compare
nicolas-grekas
approved these changes
May 25, 2021
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 1, 2021
…r (jderusse) This PR was merged into the 5.4 branch. Discussion ---------- [HttpKernel] Provide migration path for TestSessionListener | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - When working on #41321 I realized that #41343 was wrong for `TestSessionListener`. Injecting the factory in both SessionListener AND TestSessionListener would generate 2 distinguished session instances which is the opposite of the expected behavior: TestSessionListener needs the session used by the request to set the right sessionId in the cookie. This PR fallback to `request->getSession()` when there is no session injected in the container (ie: FrameworkBundlke:6) Commits ------- b56606e Provide migration path for TestSessionListener
nicolas-grekas
added a commit
that referenced
this pull request
Sep 7, 2021
…erusse) This PR was merged into the 6.0 branch. Discussion ---------- [FrameworkBundle] Remove deprecate session service | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - To ease code review this PR only removes code for session. Blocked by #41343 Commits ------- 9e6a3d3 Remove deprecate session service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sessionservice will be removed in FrameworkBundle 6, this PR make sure the session listener 5.4 will be compatible with FrameworkBundle 6.0