[Ldap] Removed deprecated code #41363
Conversation
|
Can you have a look at the Psalm error? |
I will revert the deletion of the methods. Probably it's better to delete it if somebody starts to clean up the |
| @@ -70,9 +69,6 @@ public function onCheckPassport(CheckPassportEvent $event) | |||
| } | |||
|
|
|||
| $user = $passport->getUser(); | |||
| if (!$user instanceof PasswordAuthenticatedUserInterface) { | |||
| trigger_deprecation('symfony/ldap', '5.3', 'Not implementing the "%s" interface in class "%s" while using password-based authenticators is deprecated.', PasswordAuthenticatedUserInterface::class, get_debug_type($user)); | |||
There was a problem hiding this comment.
Should this now also a exception?
There was a problem hiding this comment.
IMHO it does not need to, we can just remove the deprecation here.
Reason for this notice to be here is that in order to remove getPassword() from the generic UserInterface, we needed to trigger deprecation notices from as much places as possible to make sure developers get it. Here we don't use anything from PasswordAuthenticatedUserInterface so nothing to do.
I think, deleting |
|
Please rebase, I've merged my two PRs up. |
|
Thanks for all the PRs! I'm not sure if you were planning to, but I would propose to leave the security packages (other than this one) as-is for now. There is quite some deprecated code, as well as undeprecated but redundant code if we remove deprecation features. So we probably have to remove them per feature instead of per package. Let's make a plan when 5.3 is stable :) |
|
Thank you @malteschlueter. |
This remove deprecated code from Ldap.
Do I have to update the upgrade log for the two method deletions or is it unnecessary because it's mentioned in the security?