[Messenger] Fix ErrorDetailsStamp denormalization
#41378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we rely on |
|
Hey! I think @TimoBakx has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
@nicolas-grekas Ping on this one, still happens in production for us every now and then - let's get this reviewed and possibly merged. |
ErrorDetailsStamp denormalization
ErrorDetailsStamp denormalizationErrorDetailsStamp denormalization
|
Looks reasonable to me (should be done on 5.3 instead of 5.4 though). |
nicolas-grekas
approved these changes
Aug 26, 2021
fabpot
approved these changes
Aug 26, 2021
b323d3a to
09eec5e
Compare
|
Thank you @wucdbm. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39689
Trouble is, tests did not cover cases where a
PropertyTypeExtractorInterfaceis used, in conjunction with a variable type such asint|mixedIMO this does not really fix the issue with the Serializer component, it being that if we have mixed, we should really be allowing anything. Another point is whether that type makes sense and shouldn't be just
mixedinstead.I've changed it to
int|stringas in that context, those are the possible types, string being rather rare. I suspect a PDO Exception as I've had those in the past, there was a similar bug with FlattenException. This was a nightmare to debug/reproduce because it happened once a fortnight in production.