Skip to content

[Console] Escape synopsis output #41386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2021
Merged

[Console] Escape synopsis output #41386

merged 1 commit into from
Jun 3, 2021

Conversation

jschaedl
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41315
License MIT
Doc PR symfony/symfony-docs#...

@jschaedl jschaedl requested a review from chalasr as a code owner May 23, 2021 15:29
@chalasr
Copy link
Member

chalasr commented May 23, 2021

@jschaedl Thanks for the PR.
Can you change the PR base branch to 4.4?

@chalasr chalasr added this to the 4.4 milestone May 23, 2021
@jschaedl jschaedl changed the base branch from 5.4 to 4.4 May 23, 2021 15:37
@jschaedl
Copy link
Contributor Author

jschaedl commented May 23, 2021 •
edited
Loading

Hi @chalasr

Can you change the PR base branch to 4.4?

Sure. It was actually meant for and based on 4.4. 🙈

@jschaedl jschaedl force-pushed the fix-41315 branch 3 times, most recently from f62719d to 6ee41c6 Compare May 23, 2021 17:52
chalasr
chalasr reviewed May 23, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

@chalasr chalasr mentioned this pull request Jun 1, 2021
Closed
@nicolas-grekas
Copy link
Member

Thank you @jschaedl.

@nicolas-grekas nicolas-grekas merged commit d7524e6 into symfony:4.4 Jun 3, 2021
@jschaedl jschaedl deleted the fix-41315 branch June 3, 2021 11:56
@fabpot fabpot mentioned this pull request Jun 17, 2021
Merged
This was referenced Jun 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Console] Command usage output invalid if argument name is a reserved style
4 participants
@jschaedl @chalasr @nicolas-grekas @carsonbot