[WebProfilerBundle] Improved the light/dark theme switching #41432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would go with a bugfix based on your explanation |
stof
reviewed
May 29, 2021
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base.html.twig
Show resolved
Hide resolved
stof
reviewed
May 29, 2021
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/settings.html.twig
Outdated
Show resolved
Hide resolved
|
The title says it all, it's an improvement, so this should target 5.4. |
c93f986 to
f5e19a1
Compare
|
Rebased to 5.4. Thanks! |
|
Please, tell me if I should make any other change or improvement here. Thanks! |
wouterj
approved these changes
Jun 23, 2021
fabpot
approved these changes
Jun 23, 2021
f5e19a1 to
a9fb853
Compare
|
Thank you @javiereguiluz. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I think this is a bug fix ... but maybe you prefer to consider it a new feature.The current Symfony Profiler works like this:
The problem is that when you choose a theme explicitly, the "auto" theme is no longer available. You need to delete the local storage of your browser.
This PR makes it explicit the "auto theme" already available in the Profiler. That way, you can set "light", "dark" or "auto" explicitly:
It also changes the "theme listener" to respond instantly to OS changes, without having to refresh the page.