[FrameworkBundle] Always dump the container as XML #41457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2f05c4 to
40c45a7
Compare
stof
reviewed
May 31, 2021
src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php
Outdated
Show resolved
Hide resolved
40c45a7 to
21d9c1e
Compare
|
Closing as that's not required to prevent |
|
Could you elaborate? With this PR, |
|
See #41458 |
|
Note that we could decide to reopen this PR and merge it in 5.4, but that'd need a dedicated discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping the container as XML in prod too prevents compiling it twice on
cache:warmup, when egConfigBuilderCacheWarmerruns, or whendebug:containerordebug:routerrun.