[Serializer][Validator] Fix not null return from "getCollectionValueTypes" #41463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c428704 to
c4dcfd1
Compare
| @@ -473,13 +473,13 @@ private function validateAndDenormalize(string $currentClass, string $attribute, | |||
| if (null !== $collectionKeyType = $type->getCollectionKeyTypes()) { | |||
| [$context['key_type']] = $collectionKeyType; | |||
| } | |||
| } elseif ($type->isCollection() && null !== ($collectionValueType = $type->getCollectionValueTypes()) && \count($collectionValueType) > 0 && Type::BUILTIN_TYPE_ARRAY === $collectionValueType[0]->getBuiltinType()) { | |||
| } elseif ($type->isCollection() && \count($collectionValueType = $type->getCollectionValueTypes()) > 0 && Type::BUILTIN_TYPE_ARRAY === $collectionValueType[0]->getBuiltinType()) { | |||
There was a problem hiding this comment.
the argument of count() can never be null? (same below)
There was a problem hiding this comment.
This method has been introduced in symfony/property-info: 5.3 and the method is typehinted to return an array.
nicolas-grekas
approved these changes
May 31, 2021
nicolas-grekas
approved these changes
May 31, 2021
dunglas
approved these changes
Jun 1, 2021
|
Thank you @jderusse. |
Merged
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
…etCollectionValueTypes" (jderusse)
This PR was merged into the 5.3 branch.
Discussion
----------
[Serializer][Validator] Fix not null return from "getCollectionValueTypes"
| Q | A
| ------------- | ---
| Branch? | 5.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Currently experimenting `An exception has been thrown during the rendering of a template ("Notice: Undefined offset: 0").`
When a property is an array and PropertyInfo is not able to guess the type of CollectionValue
Commits
-------
c4dcfd1 Fix not null return from "getCollectionValueTypes"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently experimenting
An exception has been thrown during the rendering of a template ("Notice: Undefined offset: 0").When a property is an array and PropertyInfo is not able to guess the type of CollectionValue