Skip to content

[Serializer][Validator] Add conflict with property-info < 5.3 #41469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2021
Merged

[Serializer][Validator] Add conflict with property-info < 5.3 #41469

merged 1 commit into from
May 31, 2021

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Both components uses the getCollectionValueTypes method from property-info that has been introduced in 5.3 in #39020

symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php

Line 415 in 3581145

$collectionValueType = $type->isCollection() ? $type->getCollectionValueTypes()[0] ?? null : null;

symfony/src/Symfony/Component/Validator/Mapping/Loader/PropertyInfoLoader.php

Line 122 in 3581145

if ($types[0]->isCollection() && (null !== $collectionValueType = $types[0]->getCollectionValueTypes())) {

@jderusse jderusse requested a review from dunglas as a code owner May 31, 2021 16:45
@carsonbot carsonbot added this to the 5.3 milestone May 31, 2021
@carsonbot carsonbot changed the title Add conflict with property-info < 5.3 [Serializer][Validator] Add conflict with property-info < 5.3 May 31, 2021
@derrabus
Copy link
Member

Thank you Jérémy.

@derrabus derrabus merged commit 925bf86 into symfony:5.3 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed Validator
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jderusse @derrabus @nicolas-grekas @carsonbot