-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security] Readd deprecated methods to the interfaces #41493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This updates the makers for symfony/symfony#41493
b462bc3
to
c23455e
Compare
c23455e
to
f1285f4
Compare
f1285f4
to
b024656
Compare
For more details see symfony/symfony#41493 Additionally removed symfony/cache conflicts as they no longer apply (we're requiring ^5.2.0)
Thank you @wouterj. |
In my User I had to readd the old method:
As I understand it, I could remove the new method that will be re-introduced for the 6.0 BC? |
yeah, the |
Don't remove the new method. Keep both methods for now and drop |
This updates the makers for symfony/symfony#41493
This updates the makers for symfony/symfony#41493
…outerj, weaverryan) This PR was merged into the 1.0-dev branch. Discussion ---------- [make:user] Keep implementing deprecated username methods This updates the makers for symfony/symfony#41493 (where these methods are reintroduced to the interface for 5.3.1) Commits ------- 2d9312e Fix tests bd55d19 Update src/Resources/skeleton/security/UserProvider.tpl.php c3d4046 Still implement deprecated username method
Readd the deprecated methods to the interface, to make sure third party packages <5.3 work with objects created using the 5.3+ interfaces.
I've tested in a project and the deprecation is not triggered when implementing the method, only when calling. So this should still allow applications to be deprecation free in 5.4.