[SecurityBundle] Link UserProviderListener to correct firewall dispatcher #41509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test case if possible? |
79d3ab1 to
d65695d
Compare
|
@nicolas-grekas I added some functional tests (Feel like this was the better way to get failing tests first). Do you have a suggestion to fix the Travis ci bugs? I feel like it used the Symfony 5.4 branch to run tests against. |
d65695d to
0a713f2
Compare
I'd say, the Travis failure is unrelated to your changes. |
stof
reviewed
Jun 2, 2021
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Show resolved
Hide resolved
0a713f2 to
46bdeb8
Compare
chalasr
approved these changes
Jun 2, 2021
|
Thank you @Matth--. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new AuthenticationManager, an incorrect UserProvider could be attached to the UserBadge when having multiple providers defined in
security.yaml.The
UserProviderListenerwas tagged to the global event dispatcher instead of the dispatcher for the specific firewall.