Skip to content

Relax requirement on symfony/runtime #41512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jun 2, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

It looks like we have an issue with runtime:

rio ~/rio/server/backend composer out
[...]
symfony/symfony           v5.3.0  v5.3.1 The Symfony PHP framework
rio ~/rio/server/backend composer why-not symfony/symfony:v5.3.1
symfony/symfony         v5.3.1      requires          symfony/runtime (self.version)             
jolicode/redirectionio  dev-master  does not require  symfony/runtime (but v5.3.0 is installed)

So symfony/symfony require symfony/runtime with "self.version"
But symfony/runtime 5.3.1 does not exist

=> so symfony/symfony 5.3.1 is not installable

@nicolas-grekas
Copy link
Member

I would prefer to move that to require-dev.
Maintaining that line is going to be pain.

@stof
Copy link
Member

stof commented Jun 2, 2021

I don't understand the maintenance concern here. This line only needs an update for each minor version (unless a prefer-lowest job requires bumping the min version at some point, but that's the same workload than for component dependencies)

@nicolas-grekas
Copy link
Member

Releasing a new symfony version is a highly involving task. The more things we have to do, the more error prone it is.

@lyrixx
Copy link
Member Author

lyrixx commented Jun 2, 2021

So, what should I do?

@stof
Copy link
Member

stof commented Jun 2, 2021

@nicolas-grekas but here, there is nothing to do at each release, only when bumping to a new minor version.
If you don't want to accept that PR, you have to ensure that symfony/runtime never skips a patch release.

@nicolas-grekas
Copy link
Member

only when bumping to a new minor version

yes, that's what I mean. The releasing process is tedious enough, I know by experience.
what's the issue with moving this to require-dev?

@lyrixx
Copy link
Member Author

lyrixx commented Jun 2, 2021

Why does it need to be required in dev, since the component is already installed / included in the mono repo?

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 2, 2021

Because it is a composer-plugin, so it can't just be replaced.

@stof
Copy link
Member

stof commented Jun 2, 2021

what's the issue with moving this to require-dev?

do we actually use symfony/runtime for the dev requirements ? AFAICT, it was added in the composer.json so that projects installing symfony/symfony get the new runtime component too.
A solution might be to remove the requirement entirely. the runtime component is not used by other components. It is used by the skeleton. And projects using symfony/symfony are not using a runtime-based skeleton (and if they want to migrate their own project to use a runtime-based front controller, they can require it in their own project)

@nicolas-grekas
Copy link
Member

I think that's used by tests yes. But that's simple to validate :)

@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit 198448e into symfony:5.3 Jun 2, 2021
@lyrixx lyrixx deleted the runtime branch June 2, 2021 15:49
@fabpot fabpot mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants