[FrameworkBundle] Deprecate the public profiler service to private
#41530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jun 3, 2021
54f8fe7 to
06b13c3
Compare
bykclk
approved these changes
Jun 3, 2021
chalasr
approved these changes
Jun 4, 2021
fancyweb
approved these changes
Jun 4, 2021
derrabus
approved these changes
Jun 6, 2021
smilesrg
added a commit
to smilesrg/symfony
that referenced
this pull request
Jun 15, 2021
nicolas-grekas
added a commit
that referenced
this pull request
Jun 17, 2021
…_container" (smilesrg) This PR was merged into the 5.2 branch. Discussion ---------- [FrameworkBundle] fix Could not find service "test.service_container" | Q | A | ------------- | --- | Branch? | 5.2, needs to be ported to 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41715 | License | MIT Partial backport of #41530 Related to #41715 and #41530 When launching phpunit, got an error: `LogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true".` ``` There was 1 error: 1) App\Symfony\Bundle\Tests\Integration\IntegrationTest::testServiceWiringWithConfiguration LogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true". /Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:109 /Projects/app/tests/integration/IntegrationTest.php:23 Caused by Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "test.service_container". Did you mean this: "service_container"? /Projects/app/vendor/symfony/dependency-injection/Container.php:280 /Projects/app/vendor/symfony/dependency-injection/Container.php:228 /Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:107 /Projects/app/tests/integration/IntegrationTest.php:23 ``` /cc `@xabbuh` `@nicolas`-grekas Commits ------- 0748b52 bug #41715: [FrameworkBundle] Partial backport of PR#41530
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jun 17, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One less public service \o/