Skip to content

[VarDumper] Add casters for Symfony UUIDs and ULIDs #41540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2021
Merged

[VarDumper] Add casters for Symfony UUIDs and ULIDs #41540

merged 1 commit into from
Jun 12, 2021

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Jun 4, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Before:
Screenshot from 2021-06-04 10-29-30

After:
Screenshot from 2021-06-11 14-18-48

@fancyweb fancyweb force-pushed the var-dumper/uid-caster branch from 260796d to b702a5e Compare June 4, 2021 08:57
@derrabus derrabus added this to the 5.4 milestone Jun 4, 2021
derrabus
derrabus requested changes Jun 4, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add symfony/uid to VarDumper's dev dependencies, see the Travis failures.

@fancyweb fancyweb force-pushed the var-dumper/uid-caster branch from b702a5e to 1b2a812 Compare June 4, 2021 10:19
@fancyweb
Copy link
Contributor Author

fancyweb commented Jun 4, 2021

Than you @derrabus, failures looks unrelated now :-)

@fancyweb fancyweb force-pushed the var-dumper/uid-caster branch from 1b2a812 to 8817906 Compare June 4, 2021 11:28
@fancyweb fancyweb force-pushed the var-dumper/uid-caster branch from 8817906 to 533b05c Compare June 11, 2021 12:19
@fancyweb fancyweb force-pushed the var-dumper/uid-caster branch from 533b05c to 0dde2cc Compare June 11, 2021 12:21
@fancyweb fancyweb mentioned this pull request Jun 11, 2021
Merged
nicolas-grekas added a commit that referenced this pull request Jun 12, 2021
@nicolas-grekas
minor #41677 [Uid] Realign inspect commands labels (fancyweb)
57e1952 
This PR was merged into the 5.3 branch.

Discussion
----------

[Uid] Realign inspect commands labels

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Realign inspect commands labels with what we decided in #41540

Commits
-------

9cf7fbc [Uid] Realign inspect commands labels
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 2a3c003 into symfony:5.4 Jun 12, 2021
This was referenced Nov 5, 2021
Merged
Merged
@fancyweb fancyweb deleted the var-dumper/uid-caster branch January 29, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof left review comments

@ro0NL ro0NL ro0NL left review comments

@derrabus derrabus derrabus approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed VarDumper
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
8 participants
@fancyweb @nicolas-grekas @javiereguiluz @stof @OskarStark @ro0NL @derrabus @carsonbot