[DependencyInjection] Don't pass null to trim() #41557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Jun 5, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Part of #41552 |
| License | MIT |
| Doc PR | N/A |
jderusse
reviewed
Jun 6, 2021
| @@ -2147,7 +2147,9 @@ private function getClasses(Definition $definition): array | |||
| $classes = []; | |||
|
|
|||
| while ($definition instanceof Definition) { | |||
| $classes[] = trim($definition->getClass(), '\\'); | |||
| if ($class = $definition->getClass()) { | |||
| $classes[] = trim($class, '\\'); | |||
There was a problem hiding this comment.
maybe we can now remove array_filter($classes) at line 2169?
There was a problem hiding this comment.
The array_filter would still remove empty strings. I don't know if that's a thing here.
There was a problem hiding this comment.
removed in 40992f0 as I don't think the empty can get in (or if it does, that's because of a broken factory definition anyway)
javiereguiluz
approved these changes
Jun 6, 2021
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.