[FrameworkBundle] Introduced new method for getting bundles config path #41566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8192fab to
464a2cb
Compare
464a2cb to
2b1b963
Compare
|
@nicolas-grekas are there some other problems that should be fixed? |
2b1b963 to
b81b489
Compare
nicolas-grekas
approved these changes
Sep 8, 2021
fabpot
approved these changes
Sep 8, 2021
|
Thank you @a-menshchikov. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Sep 23, 2021
…sPath with Multiple Kernels (a-menshchikov) This PR was merged into the 5.4 branch. Discussion ---------- [Configuration] Using MicroKernelTrait::getBundlesPath with Multiple Kernels See symfony/symfony#41566 Commits ------- a69f6b3 MicroKernelTrait::getBundlesPath
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment bundles path duplicated in MicroKernelTrait: in
registerBundlesandregisterContainerConfigurationmethods. This leads to need to override the both methods if bundles config stored by custom path (e.g. when multiple kernels used).The new method allows override the only itself when custom path is used.