[Config] Add parameter types #41575
Merged
[Config] Add parameter types #41575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Jun 6, 2021
derrabus
commented
Jun 6, 2021
| @@ -52,7 +52,7 @@ public function __construct(ContainerBuilder $container, FileLocatorInterface $l | |||
| * | |||
| * @param bool|string $ignoreErrors Whether errors should be ignored; pass "not_found" to ignore only when the loaded resource is not found | |||
| */ | |||
| public function import($resource, string $type = null, $ignoreErrors = false, string $sourceResource = null, $exclude = null) | |||
| public function import(mixed $resource, string $type = null, bool | string $ignoreErrors = false, string $sourceResource = null, $exclude = null) | |||
There was a problem hiding this comment.
I've omitted the type declaration for $exclude in order to maintain compatibility with Config 5.4. Shall I keep it that way or shall I bump?
|
Hey! I think @jschaedl has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
derrabus
added a commit
that referenced
this pull request
Jun 9, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [Config] Backport type declarations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This PR backports type declarations from #41575 where it's safe to do so. Commits ------- 46e18af [Config] Backport type declarations
5aa99b3 to
a9e75c2
Compare
9fada46 to
4754580
Compare
src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Config/Tests/Definition/ScalarNodeTest.php
Outdated
Show resolved
Hide resolved
35eec33 to
7ec2142
Compare
nicolas-grekas
approved these changes
Jun 29, 2021
src/Symfony/Component/Config/Tests/Definition/NormalizationTest.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander M. Turek <me@derrabus.de>
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parameter types to all methods of the Config component.