Skip to content

[Cache] Add Union Types #41587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ValentineBoineau
Copy link
Contributor

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Extracted from #41424

@carsonbot carsonbot changed the title [Cache]Add Union Type Add Union Type Jun 7, 2021
@ValentineBoineau ValentineBoineau changed the title Add Union Type Add Union Types Jun 7, 2021
@ValentineBoineau ValentineBoineau changed the title Add Union Types [Cache] Add Union Types Jun 7, 2021
@ValentineBoineau ValentineBoineau force-pushed the add-union-type-doctrineprovider branch 12 times, most recently from cf03cc2 to c8eaa9e Compare June 8, 2021 12:28
@nicolas-grekas nicolas-grekas added this to the 6.0 milestone Jun 8, 2021
@ValentineBoineau ValentineBoineau force-pushed the add-union-type-doctrineprovider branch 4 times, most recently from 53c2842 to 8d70d80 Compare June 8, 2021 14:28
@ValentineBoineau ValentineBoineau force-pushed the add-union-type-doctrineprovider branch from 8d70d80 to d60d227 Compare June 8, 2021 15:22
@nicolas-grekas
Copy link
Member

This PR collides with #41290 from @derrabus, I fear we might prefer closing it in favor of #41290, since return types must be added at the same time as arguments because of the PSR dependency...

@derrabus
Copy link
Member

derrabus commented Jun 8, 2021

We can finish this PR first and I'll happily rebase mine afterwards.

@nicolas-grekas
Copy link
Member

Can we? Because we support psr/cache v1, we cannot update argument types...

@derrabus
Copy link
Member

derrabus commented Jun 8, 2021

#41290 was about adding return types. For now, I'd skip the argument types coming from PSR Cache because that is a bit more complicated. For instance, the integration test suite we're using does not handle them well yet.

So, let's make this PR about adding parameter types to all methods except the psr/cache implementations and iterate further afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants