[Serializer] Add option to skip uninitialized typed properties #41615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c235b2 to
d129544
Compare
d129544 to
9cb2dc3
Compare
|
Hey! I think @mkrauser has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
a73c938 to
c0fb162
Compare
src/Symfony/Component/Serializer/Tests/Normalizer/Features/SkipUninitializedValuesTestTrait.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/Features/TypedPropertiesObject.php
Outdated
Show resolved
Hide resolved
6b733b4 to
9cc7bd2
Compare
Done. Thanks for the help with low deps issue. The failing test now does not seem to have anything in common with my changes. |
nicolas-grekas
approved these changes
Sep 8, 2021
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
9cc7bd2 to
1b9ee7e
Compare
derrabus
approved these changes
Sep 8, 2021
|
Thank you @vuryss. |
This was referenced Nov 5, 2021
Merged
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 26, 2022
…ES option (vuryss, ivannemets-sravniru) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Documenting the new SKIP_UNINITIALIZED_VALUES option Documents changes introduced here: symfony/symfony#41615 Original issue: symfony/symfony#40578 Docs issue: #15785 Commits ------- 08599e8 Update serializer.rst 034f0f6 [Serializer] Documenting the new SKIP_UNINITIALIZED_VALUES option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to skip uninitialized values from Serializer. This is useful when using typed properties in 7.4 and those without default values should not be included in the result.
This works correctly when we're not using serializer groups, but when using the groups - it breaks badly, so it's also kind of a fix in addition to feature.