[PasswordHasher] Add union types #41640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
01da7b0 to
fe3fdfd
Compare
stof
requested changes
Jun 9, 2021
src/Symfony/Component/PasswordHasher/Hasher/PasswordHasherFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PasswordHasher/Hasher/UserPasswordHasher.php
Outdated
Show resolved
Hide resolved
fe3fdfd to
5005cdf
Compare
chalasr
reviewed
Jun 9, 2021
9df0ac9 to
2af3710
Compare
b47497f to
e0a3ad3
Compare
f99c3be to
501b827
Compare
nicolas-grekas
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
With some nitpicking.
@chalasr shouldn't we backport some changes to 5.3?
src/Symfony/Component/PasswordHasher/Hasher/PasswordHasherFactoryInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PasswordHasher/Tests/Hasher/PasswordHasherFactoryTest.php
Outdated
Show resolved
Hide resolved
501b827 to
b57bce2
Compare
chalasr
added a commit
that referenced
this pull request
Jun 11, 2021
…allowed type (chalasr) This PR was merged into the 5.3 branch. Discussion ---------- [PasswordHasher] Fix missing PasswordHasherAwareInterface allowed type | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Also backports test changes from #41640 Commits ------- 8d3bea5 [PasswordHasher] Fix missing PasswordHasherAwareInterface allowed type in signatures
chalasr
requested changes
Jun 11, 2021
stof
reviewed
Jun 11, 2021
src/Symfony/Component/PasswordHasher/Hasher/PasswordHasherFactoryInterface.php
Outdated
Show resolved
Hide resolved
chalasr
added a commit
that referenced
this pull request
Jun 11, 2021
…e from UserPasswordHasherInterface API (chalasr) This PR was merged into the 5.3 branch. Discussion ---------- [PasswordHasher] Remove PasswordHasherAwareInterface type from UserPasswordHasherInterface API | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no (not yet released) | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As spotted by `@stof` in #41640 (comment), the methods of this interface should not handle user classes/instances that are not implementing `PasswordAuthenticatedUserInterface`. This reverts that part from #41678 (not released yet). Commits ------- 596ba78 [PasswordHasher] Remove PasswordHasherAwareInterface from UserPasswordHasherInterface API
b57bce2 to
8628479
Compare
chalasr
approved these changes
Jun 11, 2021
|
Thank you @ValentineBoineau. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #41424