Skip to content

[Serializer] Remove deprecation layer #41657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2021
Merged

[Serializer] Remove deprecation layer #41657

merged 1 commit into from
Jul 3, 2021

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@derrabus derrabus requested a review from dunglas as a code owner June 10, 2021 17:51
@carsonbot carsonbot added this to the 6.0 milestone Jun 10, 2021
@derrabus derrabus force-pushed the remove/serializer-deprecations branch from b608c8e to 40042a6 Compare June 10, 2021 17:56
@carsonbot
Copy link

Hey!

I think @xfifix has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@derrabus derrabus force-pushed the remove/serializer-deprecations branch from 40042a6 to f6a01e8 Compare June 14, 2021 11:51
@derrabus derrabus force-pushed the remove/serializer-deprecations branch from f6a01e8 to 222ea81 Compare June 27, 2021 13:40
nicolas-grekas
nicolas-grekas reviewed Jun 29, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase so that we can see green tests :)

@derrabus derrabus force-pushed the remove/serializer-deprecations branch from 222ea81 to 42061be Compare June 29, 2021 13:13
@derrabus
Copy link
Member Author

Fabbot failure is the usual false positive, AppVeyor failure is unrelated. The remaining tests are green.

OskarStark
OskarStark reviewed Jun 30, 2021
View reviewed changes
src/Symfony/Component/Serializer/Annotation/Context.php
}
}

public function __construct(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be on one line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using constructor property promotion, I think we should use several lines actually
we do so already for attributes

src/Symfony/Component/Serializer/Annotation/DiscriminatorMap.php
throw new \TypeError(sprintf('"%s": Argument $typeProperty was expected to be a string or array, got "%s".', __METHOD__, get_debug_type($typeProperty)));
}

public function __construct(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@derrabus @nicolas-grekas
[Serializer] Remove deprecation layer
56034b5 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@nicolas-grekas nicolas-grekas force-pushed the remove/serializer-deprecations branch from 42061be to 56034b5 Compare July 3, 2021 20:23
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 4dae21b into symfony:6.0 Jul 3, 2021
@fabpot fabpot mentioned this pull request Nov 5, 2021
Merged
@derrabus derrabus deleted the remove/serializer-deprecations branch November 21, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark left review comments

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Serializer Status: Needs Review
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @carsonbot @nicolas-grekas @OskarStark