Skip to content

[SecurityBundle] Create a smooth upgrade path for security factories #41754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2021
Merged

[SecurityBundle] Create a smooth upgrade path for security factories #41754

merged 1 commit into from
Aug 7, 2021

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jun 20, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Ref #41613 (comment)
License MIT
Doc PR -

This change allows removing SecurityFactoryInterface in Symfony 6.

I've also changed the discrete ordering using "listener positions" to the much more common continuous ordering using priorities. I feel like priorities are much more self-explanatory.

@wouterj wouterj requested a review from chalasr as a code owner June 20, 2021 12:31
@wouterj wouterj force-pushed the pull-41613/authenticator-factory branch from 7903986 to fc667f4 Compare June 20, 2021 13:21
@wouterj wouterj mentioned this pull request Jun 20, 2021
Merged
@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Jun 21, 2021
@wouterj wouterj force-pushed the pull-41613/authenticator-factory branch from fc667f4 to 3a5ac34 Compare June 27, 2021 10:40
@StaffNowa
Copy link
Contributor

Please make fabbot happy 😊

@wouterj wouterj force-pushed the pull-41613/authenticator-factory branch 2 times, most recently from e81ff82 to 5b54abc Compare July 1, 2021 19:19
@wouterj
Copy link
Member Author

wouterj commented Jul 1, 2021

This is as green as this PR will get. The remaining errors are false positives.

@wouterj wouterj force-pushed the pull-41613/authenticator-factory branch from 5b54abc to 0172e56 Compare July 3, 2021 10:35
@wouterj wouterj force-pushed the pull-41613/authenticator-factory branch from 0172e56 to 9c44ad6 Compare July 3, 2021 21:21
@chalasr
Copy link
Member

chalasr commented Jul 14, 2021

small rebase needed

@wouterj wouterj force-pushed the pull-41613/authenticator-factory branch from 9c44ad6 to 7385fd5 Compare August 7, 2021 15:12
@wouterj
Copy link
Member Author

wouterj commented Aug 7, 2021

Sorry for the delay, I forgot this one was still open. Rebased and ready :)

@chalasr
Copy link
Member

chalasr commented Aug 7, 2021

Thanks Wouter.

@chalasr chalasr mentioned this pull request Aug 7, 2021
Closed
@chalasr chalasr merged commit 8e984fa into symfony:5.4 Aug 7, 2021
@wouterj wouterj deleted the pull-41613/authenticator-factory branch August 7, 2021 16:28
@mbabker mbabker mentioned this pull request Aug 11, 2021
Merged
This was referenced Nov 5, 2021
Merged
Merged
@chalasr chalasr mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abunch abunch abunch left review comments

@chalasr chalasr chalasr left review comments

@fabpot fabpot fabpot requested changes

Assignees
No one assigned
Labels
Deprecation Feature SecurityBundle Status: Needs Work
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@wouterj @StaffNowa @chalasr @fabpot @abunch @nicolas-grekas @carsonbot