Skip to content

[FrameworkBundle] fix removing "action" from route names #41782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 22, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40024
License MIT
Doc PR -

@ro0NL
Copy link
Contributor

ro0NL commented Jun 22, 2021

should we change default names in a patch release?

@stof
Copy link
Member

stof commented Jun 22, 2021

This will break all URL generation that uses the existing names. So it might indeed be dangerous in a patch release

@ro0NL
Copy link
Contributor

ro0NL commented Jun 22, 2021

also, from my experience, dereferencing virtual route names is pure pain :D

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Jun 22, 2021

This will break all URL generation that uses the existing names. So it might indeed be dangerous in a patch release

Only when an action method doesn't end with Action nor _action, but still ends with action, in a case-sensitive way.

I'm fine doing this on 5.4...

@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 5.4 June 23, 2021 18:44
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 5.4 Jun 23, 2021
@nicolas-grekas
Copy link
Member Author

Now targetting 5.4

@nicolas-grekas
Copy link
Member Author

@Tobion comments addressed, thanks for the review!

@Tobion
Copy link
Contributor

Tobion commented Jul 7, 2021

Thank you @nicolas-grekas.

@Tobion Tobion merged commit 83825c5 into symfony:5.4 Jul 7, 2021
@nicolas-grekas nicolas-grekas deleted the fwb-route-name branch July 15, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller actions ending with words like "action" are removing the "action" part from route name
6 participants