-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] fix removing "action" from route names #41782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nicolas-grekas
commented
Jun 22, 2021
•
edited
Loading
edited
Q | A |
---|---|
Branch? | 5.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #40024 |
License | MIT |
Doc PR | - |
beb5c0f
to
98f82fe
Compare
should we change default names in a patch release? |
This will break all URL generation that uses the existing names. So it might indeed be dangerous in a patch release |
also, from my experience, dereferencing virtual route names is pure pain :D |
Only when an action method doesn't end with I'm fine doing this on 5.4... |
Now targetting 5.4 |
...Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Controller/AnnotatedController.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Routing/AnnotatedRouteControllerLoader.php
Outdated
Show resolved
Hide resolved
98f82fe
to
7f4a84f
Compare
@Tobion comments addressed, thanks for the review! |
Thank you @nicolas-grekas. |