[Uid] Add NilUlid #41802
Merged
[Uid] Add NilUlid #41802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Jun 23, 2021
src/Symfony/Component/Uid/Ulid.php
Outdated
| @@ -67,10 +67,14 @@ public static function fromString(string $ulid): parent | |||
| if (36 === \strlen($ulid) && Uuid::isValid($ulid)) { | |||
| $ulid = (new Uuid($ulid))->toBinary(); | |||
| } elseif (22 === \strlen($ulid) && 22 === strspn($ulid, BinaryUtil::BASE58[''])) { | |||
| $ulid = BinaryUtil::fromBase($ulid, BinaryUtil::BASE58); | |||
| $ulid = str_pad(BinaryUtil::fromBase($ulid, BinaryUtil::BASE58), 16, "\0", \STR_PAD_LEFT); | |||
nicolas-grekas
approved these changes
Jun 23, 2021
chalasr
approved these changes
Jun 23, 2021
ogizanagi
reviewed
Jun 24, 2021
derrabus
approved these changes
Jun 27, 2021
fabpot
approved these changes
Jun 27, 2021
|
Thank you @fancyweb. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NilUlidis not really official but I think it would be useful. The goal is to be able to donew NilUlid();instead ofnew Ulid('00000000000000000000000000');and therefore to detect it more easily (like for theNilUuid). Currently I'm creating the class manually. My use case is using it as a placeholder.