Skip to content

[Uid] Prevent double validation in Uuid::fromString() with base32 values #41803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

[Uid] Prevent double validation in Uuid::fromString() with base32 values #41803

merged 1 commit into from
Jun 23, 2021

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 5.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Follow up to #41693, it should be a little bit faster if we don't validate twice, right?

@carsonbot carsonbot added this to the 5.3 milestone Jun 23, 2021
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 8a8d2a6 into symfony:5.3 Jun 23, 2021
@fancyweb fancyweb deleted the uid/perf-1 branch June 24, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Uid
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot