Skip to content

[String] Fix skip condition for INTL #41879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2021
Merged

[String] Fix skip condition for INTL #41879

merged 1 commit into from
Aug 26, 2021

Conversation

derrabus
Copy link
Member

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix 1bbacd5#r52732121
License MIT
Doc PR N/A

@derrabus derrabus requested a review from nicolas-grekas June 28, 2021 10:39
@carsonbot carsonbot added this to the 5.2 milestone Jun 28, 2021
derrabus referenced this pull request Jun 28, 2021
@nicolas-grekas
Fix CI
1bbacd5
@nicolas-grekas
Copy link
Member

They don't, I still get the failures from #38957.

We should report the issue to ICU...

@derrabus
Copy link
Member Author

They don't, I still get the failures from #38957.

We should report the issue to ICU...

I don't feel like I know enough about unicode to write a proper bug report. 😓

@nicolas-grekas
Copy link
Member

Reported at https://unicode-org.atlassian.net/browse/CLDR-14861

@fabpot fabpot modified the milestones: 5.2, 5.3 Jul 26, 2021
@derrabus @nicolas-grekas
Fix skip condition for INTL
4d6ad98 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@nicolas-grekas nicolas-grekas changed the base branch from 5.2 to 5.3 August 26, 2021 08:00
@nicolas-grekas nicolas-grekas force-pushed the bugfix/skip-intl-tests branch from d5974fe to 4d6ad98 Compare August 26, 2021 08:00
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 7e57120 into symfony:5.3 Aug 26, 2021
@derrabus derrabus deleted the bugfix/skip-intl-tests branch December 15, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Status: Reviewed Status: Waiting feedback String
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @nicolas-grekas @xabbuh @fabpot @carsonbot