[Security] Handle concurency in Csrf DoctrineTokenProvider #41910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jun 30, 2021
|
Thank you @jderusse. |
Merged
fabpot
added a commit
that referenced
this pull request
Jul 3, 2021
This PR was merged into the 5.3 branch. Discussion ---------- Rethrow exception in `DoctrineTokenProvider` | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Introduced in #41910 Commits ------- 246e679 rethrow caught exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
PersistentRememberMeHandlerclass process aRememberMecookie older than 1 minute it can tells thetokenVerifierto update it. This method performs adeletethen aninsert. This could be an issue with concurrent requests leading toUniqueConstraintViolationException.This PR wrap the delete/insert in a transaction to prevent this.