[DependencyInjection] Add types to private properties #41928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 1, 2021
stof
reviewed
Jul 1, 2021
src/Symfony/Component/DependencyInjection/Compiler/AliasDeprecatedPublicServicesPass.php
Show resolved
Hide resolved
|
for the Psalm false positive, I reported the bug at vimeo/psalm#6027 |
chalasr
approved these changes
Jul 1, 2021
ro0NL
reviewed
Jul 1, 2021
| @@ -194,7 +194,7 @@ protected function getReflectionMethod(Definition $definition, string $method) | |||
|
|
|||
| private function getExpressionLanguage(): ExpressionLanguage | |||
| { | |||
| if (null === $this->expressionLanguage) { | |||
| if (!isset($this->expressionLanguage)) { | |||
There was a problem hiding this comment.
the private scope confused me. But from #41924 i figured this lazy loading tactic is probably slightly preferred, as we dont need to give in on type info.
👍
There was a problem hiding this comment.
Right. null was previously used for lazy initialization only and I'd like to avoid making properties nullable. If someone accesses this property before initialization, they made a mistake and PHP will raise an exception for us. This is a good thing.
This was referenced Jul 1, 2021
fabpot
added a commit
that referenced
this pull request
Jul 2, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Fix doc blocks | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Two small backports from #41928. Commits ------- 950b2e7 [DependencyInjection] Fix doc blocks
| $this->getEnv->setAccessible(true); | ||
| $this->getEnv = $this->getEnv->getClosure($this); | ||
| } | ||
| $this->getEnv ??= \Closure::fromCallable([$this, __FUNCTION__]); |
There was a problem hiding this comment.
psalm bug here, it's not able to compute __FUNCTION__ correctly
let's use 'getEnv' instead
fabpot
added a commit
that referenced
this pull request
Jul 2, 2021
…nto a constant (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Turn $defaultDeprecationTemplate into a constant | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #41928 (comment) | License | MIT | Doc PR | N/A Commits ------- 936e399 [DependencyInjection] Turn $defaultDeprecationTemplate into a constant
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Jul 2, 2021
…nto a constant (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Turn $defaultDeprecationTemplate into a constant | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | symfony/symfony#41928 (comment) | License | MIT | Doc PR | N/A Commits ------- 936e399ff9 [DependencyInjection] Turn $defaultDeprecationTemplate into a constant
7b7588a to
069da20
Compare
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same procedure as #41924, but on a more complex component.