Fix: Mailjet bridge tests #41985
Merged
Fix: Mailjet bridge tests #41985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Jul 5, 2021
jderusse
reviewed
Jul 5, 2021
OskarStark
commented
Jul 5, 2021
OskarStark
commented
Jul 5, 2021
| @@ -39,9 +39,9 @@ public function supportsProvider(): iterable | |||
| yield [false, 'somethingElse://Mailjet:authtoken@default']; | |||
| } | |||
|
|
|||
| public function missingRequiredOptionProvider(): iterable | |||
| public function incompleteDsnProvider(): iterable | |||
There was a problem hiding this comment.
password is no option, its part of user:pass of the scheme
600a18c to
05891cf
Compare
OskarStark
commented
Jul 5, 2021
OskarStark
added a commit
to OskarStark/symfony
that referenced
this pull request
Jul 5, 2021
Needed for symfony#41985
fabpot
added a commit
that referenced
this pull request
Jul 5, 2021
This PR was merged into the 5.3 branch. Discussion ---------- [Notifier] Fix TransportTestCase | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | -- | License | MIT | Doc PR | - Needed for #41985 Commits ------- 1319a11 [Notifier] Fix TransportTestCase
|
@OskarStark #41986 has been merged now :) |
c956b37 to
da4638a
Compare
|
rebased 👍 |
|
Weird, I rebased, but why is it now failing? Because 5.3 is not released yet including the AbstractTestCase changes? |
|
You need to bump Notifier to |
|
Indeed 👍 |
da8b31a to
690e4ed
Compare
derrabus
approved these changes
Jul 5, 2021
|
Thank you Oskar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build