Skip to content

[Console][DependencyInjection] tighten types #41992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

[Console][DependencyInjection] tighten types #41992

merged 1 commit into from
Jul 5, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

See to #41991

@nicolas-grekas nicolas-grekas requested a review from chalasr as a code owner July 5, 2021 11:46
@carsonbot carsonbot added this to the 4.4 milestone Jul 5, 2021
@carsonbot carsonbot changed the title [DependencyInjection][Console] tighten types [Console][DependencyInjection] tighten types Jul 5, 2021
@fabpot
Copy link
Member

fabpot commented Jul 5, 2021

@nicolas-grekas fabbot has something for you :)

@nicolas-grekas
Copy link
Member Author

Applied!

@fabpot
Copy link
Member

fabpot commented Jul 5, 2021

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 2ed8a90 into symfony:4.4 Jul 5, 2021
@nicolas-grekas nicolas-grekas deleted the tight-types44 branch July 5, 2021 13:17
@kassner kassner mentioned this pull request Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @carsonbot