Skip to content

[Console] Fix save correct name in setDefaultCommand() for PHP8 #42009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

[Console] Fix save correct name in setDefaultCommand() for PHP8 #42009

merged 1 commit into from
Jul 8, 2021

Conversation

a1812
Copy link
Contributor

@a1812 a1812 commented Jul 6, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41942
Doc PR

Fix save correct name in setDefaultCommand() for PHP8

@a1812 a1812 requested a review from chalasr as a code owner July 6, 2021 19:49
@carsonbot carsonbot added this to the 5.3 milestone Jul 6, 2021
@duboiss
Copy link
Contributor

duboiss commented Jul 7, 2021

I don't feel that this is fixing #41942 after testing on my local project (duboiss/sfcommand, php8 branch) your modifications.

@a1812
Copy link
Contributor Author

a1812 commented Jul 7, 2021

I don't feel that this is fixing #41942 after testing on my local project (duboiss/sfcommand, php8 branch) your modifications.

and nevertheless my test shows that everything is in order :)
image

@duboiss
Copy link
Contributor

duboiss commented Jul 7, 2021

My bad, I think I made a mistake between two git clone. It's ok from my side too, nice job!

@a1812 a1812 force-pushed the fix_issue_41942 branch from 725001b to 19c8f13 Compare July 8, 2021 11:10
@a1812 a1812 force-pushed the fix_issue_41942 branch from 19c8f13 to 8a41694 Compare July 8, 2021 11:12
@a1812 a1812 requested a review from fabpot July 8, 2021 11:23
@fabpot
Copy link
Member

fabpot commented Jul 8, 2021

Thank you @a1812.

@fabpot fabpot merged commit 4a03392 into symfony:5.3 Jul 8, 2021
@a1812 a1812 deleted the fix_issue_41942 branch July 21, 2021 10:47
@fabpot fabpot mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@a1812 @duboiss @fabpot @chalasr @carsonbot