[Notifier] [Slack] Include additional errors to slack notifier error message #42090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 13, 2021
src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackTransportTest.php
Show resolved
Hide resolved
OskarStark
approved these changes
Jul 13, 2021
jderusse
approved these changes
Jul 13, 2021
|
Thanks for your work on this new feature! |
derrabus
added a commit
that referenced
this pull request
Jul 15, 2021
…is reached for slack message options (norkunas) This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] [Slack] Throw error if maximum block limit is reached for slack message options | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #42090 (comment) | License | MIT | Doc PR | N/A As requested to improve DX :) Commits ------- 4faa677 Throw error if maximum block limit is reached for slack message options
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is hard to debug why notification was rejected, so I am proposing to include error descriptions to the exception message.