-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Add $stamps
parameter to HandleTrait::handle
#42124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Messenger] Add $stamps
parameter to HandleTrait::handle
#42124
Conversation
e37a935
to
bdaa434
Compare
bdaa434
to
436e506
Compare
I rebased this branch. As I think this is a new feature and we are in RC phase I updated the changelog to 6.2. |
While having stamps part of the |
In our cases it is very important that we are allowed to input stamps. As they control our middlewares. We had very bad experience with "automated" middlewares like DoctrineFlush oder DoctrineTransactionMiddleware and creating for everything seperate message buses was a bad developer experience. So we decided to use stamps for this kind of things so developer had 100% control in the userinterface layer our messages are dispatched how the message is handled by the middlewares. And I don't see much which speak against it as it is still optional and if somebody don't want to use it they don't need it. |
Is there any chance to rediscuss this? We are using Stamps not only for Doctrine Flush but also for new YourMessage(), [new LockStamp('lock-key', 300.0, true)]) |
2f044ea
to
a652612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thanks for clarifying.
1c359b7
to
c4f3677
Compare
c4f3677
to
a61a656
Compare
just rebased, fabbot unrelated: #42124 (comment) |
a61a656
to
9d69f84
Compare
$stamps
parameter to HandleTrait::handle
Something I can do to push this over the line :) |
c3237a6
to
cb10d2e
Compare
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
7834310
to
1742f67
Compare
Thank you @alexander-schranz. |
Like the
MessageBusInterface::dispatch
it would be great to use stamps.We are using example a custom middleware to control if a flush should be done.
Also a custom middleware for locking: