Skip to content

[Translation] fix fallback to Locale::getDefault() #42130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Replaces #42128 and #38230

Provides consistent behavior with TranslatorTrait::getLocale().

@carsonbot carsonbot added this to the 4.4 milestone Jul 15, 2021
@carsonbot carsonbot changed the title [Translator] fix fallback to Locale::getDefault() [Translation] fix fallback to Locale::getDefault() Jul 15, 2021
@carsonbot
Copy link

Hey!

I think @fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@fabpot
Copy link
Member

fabpot commented Jul 20, 2021

Thank you @nicolas-grekas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants