Skip to content

[Translation] Extract translatable content on twig set #42160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

natewiebe13
Copy link
Contributor

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
License MIT

When extracting messages from Twig templates, the extractor was only considering the t() function when it was being immediately filtered by the trans filter. Instead it should be happening when the message object is created.

@carsonbot carsonbot added this to the 5.2 milestone Jul 16, 2021
@carsonbot carsonbot changed the title Extract translatable content on twig set [Translation] Extract translatable content on twig set Jul 18, 2021
@fabpot fabpot modified the milestones: 5.2, 5.3 Jul 26, 2021
@fabpot fabpot changed the base branch from 5.2 to 5.3 August 26, 2021 07:28
@fabpot
Copy link
Member

fabpot commented Aug 26, 2021

Thank you @natewiebe13.

@fabpot fabpot force-pushed the extract-translatable-content-on-twig-set branch from be782ca to ab9ad6b Compare August 26, 2021 07:28
@fabpot fabpot merged commit 67d8a59 into symfony:5.3 Aug 26, 2021
@natewiebe13 natewiebe13 deleted the extract-translatable-content-on-twig-set branch August 26, 2021 12:50
@fabpot fabpot mentioned this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants