[Messenger] [Redis] Prepare turning delete_after_ack to true in 6.0
#42163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete_after_ack to true in 6.0delete_after_ack to true in 6.0
d18171f to
80f94d4
Compare
alexander-schranz
approved these changes
Jul 17, 2021
|
Thank you @chalasr. Think consistents between to transports are important here and did lead in do past in unexpected errors. |
derrabus
added a commit
that referenced
this pull request
Jul 18, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [CI] Fix wrongly skipped integration tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The integration tests from bridges located in components (e.g. `Notifier/Bridge/Discord/Tests` or `Messenger/Bridge/Redis/Tests`) were excluded from the CI. Spotted while working on #42163 - Some redis-messenger tests are currently broken on 5.x, which we didn't spot because of the missing entry in the phpunit config. Commits ------- 438a503 [ci] Fix wrongly skipped integration tests
Nyholm
reviewed
Jul 18, 2021
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
|
Thanks for the review Tobias, suggestions applied. |
nicolas-grekas
approved these changes
Jul 19, 2021
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
0b44408 to
1439f37
Compare
|
@nicolas-grekas Thanks, all fixed |
755cf01 to
3be461b
Compare
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this option turned on makes redis-messenger much more consistent with other transports, more adapted to the 80% use case and more importantly, prevents having to deal with OOM issues.