[Notifier] Add bridge for smsc.ru #42180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Jul 18, 2021
|
Great. Thank you for this PR. It looks like a few CI jobs are complaining. Could you make sure that at least "fabbot.io" and "Package / Verify" are green? |
8901968 to
a7cfda2
Compare
|
Sure, fixed all the CI issues I could. There still is a failed test, but it seems to be unrelated. |
Nyholm
reviewed
Jul 18, 2021
2d53fe7 to
0863f6d
Compare
derrabus
reviewed
Jul 18, 2021
6b70d93 to
0a69dc2
Compare
kozlice
commented
Jul 19, 2021
Nyholm
reviewed
Jul 19, 2021
Nyholm
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Thank you.
Im happy with this PR. The psalm issue is addressed in #42183.
I think @OskarStark will be happy to review this PR later.
OskarStark
requested changes
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/Smsc/Tests/SmscTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Smsc/SmscTransportFactory.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 19, 2021
OskarStark
reviewed
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/Smsc/SmscTransport.php~Stashed changes
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/Smsc/SmscTransportFactory.php~Stashed changes
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/Smsc/Tests/SmscTransportFactoryTest.php~Stashed changes
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/Smsc/Tests/SmscTransportTest.php~Stashed changes
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Jul 19, 2021
|
Thanks Valentin for working on this feature, this is much appreciated. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 19, 2021
This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] Add bridge for smsc.ru Add Notifier brdige for smsc.ru symfony/symfony#42180 Commits ------- 5f443b9 [Notifier] Add bridge for smsc.ru
|
Thanks for the fast and detailed review, guys Here's the recipe PR: symfony/recipes#975 |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a notifier bridge for Russian SMS provider smsc.
This PR contains the new bridge and updates to framework bundle in all the places where all the other notifiers are listed.