Skip to content

[Notifier] Add FakeChat Logger transport #42188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

[Notifier] Add FakeChat Logger transport #42188

merged 1 commit into from
Aug 4, 2021

Conversation

noniagriconomie
Copy link
Contributor

@noniagriconomie noniagriconomie commented Jul 19, 2021 •
edited by OskarStark
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Sub part of #40625
License MIT
Doc PR WIP

Refs #42123 for Notifier FakeChat

@noniagriconomie noniagriconomie changed the title Add FakeChat Logger transport [Notifier] Add FakeChat Logger transport Jul 19, 2021
@OskarStark
Copy link
Contributor

Please extend UnsupportedSchemeExceptionTest, thanks

@noniagriconomie noniagriconomie changed the title [Notifier] Add FakeChat Logger transport [WIP] [Notifier] Add FakeChat Logger transport Jul 19, 2021
@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Jul 19, 2021
@noniagriconomie noniagriconomie force-pushed the ft-40625-2 branch 3 times, most recently from cca2045 to d43645e Compare July 19, 2021 12:21
@noniagriconomie noniagriconomie changed the title [WIP] [Notifier] Add FakeChat Logger transport [Notifier] Add FakeChat Logger transport Jul 19, 2021
OskarStark referenced this pull request Jul 21, 2021
@nicolas-grekas
[Notifier] cs
ef84e66
@OskarStark OskarStark requested a review from derrabus July 31, 2021 11:55
@carsonbot carsonbot changed the title [Notifier] Add FakeChat Logger transport Add FakeChat Logger transport Jul 31, 2021
@carsonbot carsonbot changed the title Add FakeChat Logger transport [Notifier] Add FakeChat Logger transport Aug 1, 2021
derrabus
derrabus requested changes Aug 1, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look at the Psalm errors?

OskarStark
OskarStark requested changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@noniagriconomie
Copy link
Contributor Author

friendly ping @OskarStark @derrabus code reworked as requested, thx

@OskarStark OskarStark requested a review from derrabus August 4, 2021 14:13
@OskarStark
Copy link
Contributor

Thanks Antoine.

@OskarStark OskarStark merged commit 7c1820d into symfony:5.4 Aug 4, 2021
@noniagriconomie noniagriconomie deleted the ft-40625-2 branch August 5, 2021 07:02
@noniagriconomie noniagriconomie mentioned this pull request Aug 6, 2021
Merged
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Aug 7, 2021
@OskarStark
feature #15596 [Notifier] Document fake chat logger notifier (noniagr…
a2b2f30 
…iconomie)

This PR was merged into the 5.4 branch.

Discussion
----------

[Notifier] Document fake chat logger notifier

Document symfony/symfony#42188 (no issue created post merge)
Follows #15595

Commits
-------

4e5845b Document fake chat logger notifier
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@noniagriconomie @OskarStark @derrabus @nicolas-grekas @carsonbot