Skip to content

[Mailer] Add support of ping_threshold to SesTransportFactory #42215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Tyraelqp
Copy link
Contributor

@Tyraelqp Tyraelqp commented Jul 21, 2021

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39044
License MIT
Doc PR -

Added support of ping_threshold option to SesTransportFactory for ses+smtp and ses+smtps schemes. Needed because SES closes SMTP connection after 10 seconds of inactivity and TransportException will be thrown on next send: Expected response code "250" but got code "451", with message "451 4.4.2 Timeout waiting for data from client.".

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

CleanShot 2021-07-21 at 14 00 21@2x

Your commiter email is not associated with your Github Account

@OskarStark
Copy link
Contributor

OskarStark commented Jul 21, 2021

The PR header targets 5.2, but the PR is against 5.4 branch

EDIT:
The referenced ticket mentioned that 4.4 is affected 🤔

@OskarStark OskarStark requested a review from jderusse July 21, 2021 12:03
@Tyraelqp Tyraelqp changed the base branch from 5.4 to 5.2 July 21, 2021 12:07
@Tyraelqp Tyraelqp closed this Jul 21, 2021
@Tyraelqp Tyraelqp deleted the ticket_39044 branch July 21, 2021 12:18
@Tyraelqp Tyraelqp restored the ticket_39044 branch July 21, 2021 12:21
@xabbuh
Copy link
Member

xabbuh commented Jul 21, 2021

@Tyraelqp A bugfix should always target the lowest affected but still maintained version (e.g. 4.4 here probably). We regularly merge branches up so that the fix will eventually land in all maintained versions.

@Tyraelqp
Copy link
Contributor Author

@OskarStark How may i change commit author? Or it's better to close this one and open new PR?

@Tyraelqp
Copy link
Contributor Author

Opened new PR to 4.4 #42219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mailer] SMTP transport with AWS SES: "Timeout waiting for data from client"
4 participants